Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we want to allow sharing mutable MediaLists across multiple sheets? #13

Closed
bzbarsky opened this issue Feb 6, 2018 · 2 comments
Closed

Do we want to allow sharing mutable MediaLists across multiple sheets? #13

bzbarsky opened this issue Feb 6, 2018 · 2 comments
Labels
needs resolution Needs consensus/resolution before shipping

Comments

@bzbarsky
Copy link

bzbarsky commented Feb 6, 2018

Right now I believe it can't happen, but the spec draft here would allow sharing a mutable MediaList across multiple sheets. Is this desired? Would cloning the MediaList in the constructor be better?
@TakayoshiKochi
Copy link
Member

Cloning the list sounds better to me.
@tabatkins what do you think?

@TakayoshiKochi TakayoshiKochi added the needs resolution Needs consensus/resolution before shipping label Apr 17, 2018
@rakina
Copy link
Member

rakina commented Jul 3, 2018

+1 in cloning instead of sharing.

@TakayoshiKochi TakayoshiKochi mentioned this issue Jul 6, 2018
Closed
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 9, 2018
@rakina
Change CSSStyleSheet constructor to produce only empty CSSStyleSheets
143f24f 
We previously implemented constructable CSSStyleSheet synchronously,
but discussions in WICG/construct-stylesheets#2
have gravitated away from that and we are now interested in asynchronous
creation of CSSStyleSheet, but also provide synchronous constructor that
only result in an empty sheet.

This CL changed the constructors to not accept CSS text. This also
changes part of the constructor where we process passed MediaList
data to copy the given MediaList instead of using the same instance
to avoid introducing the concept of mutable MediaLists.
See: WICG/construct-stylesheets#13

CL for promise-based API: crrev.com/c/1126754

Bug: 807560
Change-Id: I0aeb052b63e45d81fc46cde3052f3d134afa16fa
Reviewed-on: https://chromium-review.googlesource.com/1126898
Reviewed-by: Fergal Daly <[email protected]>
Reviewed-by: Hayato Ito <[email protected]>
Reviewed-by: Takayoshi Kochi <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#573233}
@rakina rakina mentioned this issue Aug 28, 2018
Merged
@rakina rakina closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs resolution Needs consensus/resolution before shipping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bzbarsky @TakayoshiKochi @rakina