Modify interface to allow client to choose which service to connect to #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payment method identifier is now given as a parameter to getDigitalGoodsService, rather than returned as a property. This allows the user agent to expose multiple services, letting the client choose which one to use. Closes WICG#8.
|
@danyao @phoglenix PTAL (I can't add you as a reviewer until you accept invite.) |
|
Probably want to move getDigitalGoodsService() to be a static method on PaymentRequest? We will need to figure out how this interfaces with Payment Handler API. |
|
@marcoscaceres Maybe... but for now, I am considering this as a separate feature to PR. It seems less controversial that way, than trying to add it into this existing API which is about more general payment flows. |
|
LGTM! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payment method identifier is now given as a parameter to
getDigitalGoodsService, rather than returned as a property. This allows the user agent to expose multiple services, letting the client choose which one to use.Closes #1.
Closes #8.