Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Combine hidden-matchable and beforematch explainers #184

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Combine hidden-matchable and beforematch explainers #184

merged 1 commit into from
Sep 25, 2020

Conversation

vmpstr
Copy link
Collaborator

@vmpstr vmpstr commented Sep 25, 2020

No description provided.

@vmpstr
Copy link
Collaborator Author

vmpstr commented Sep 25, 2020

Please take a look. This is sourced mostly from the beforematch explainer, with a couple of notes about hidden-matchable.

josepharhar
josepharhar approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@josepharhar josepharhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I think I definitely need to revise some of the things I've said, but maybe I'll do that after privacy discussions which could make another revision needed

@vmpstr vmpstr merged commit bc72dcf into WICG:master Sep 25, 2020
@vmpstr
Copy link
Collaborator Author

vmpstr commented Sep 25, 2020

I think I definitely need to revise some of the things I've said, but maybe I'll do that after privacy discussions which could make another revision needed

Agreed. I tried to leave it as "it is now" but left a few sentences about the fact that we are still evolving the API with considerations from both TAG and privacy

@josepharhar josepharhar mentioned this pull request Oct 2, 2020
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josepharhar josepharhar josepharhar approved these changes

@chrishtr chrishtr Awaiting requested review from chrishtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmpstr @josepharhar