move and rename getOriginPrivateDirectory to StorageManager #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
approved these changes
Aug 18, 2020
| @@ -1394,7 +1396,7 @@ run these steps: | |||
| 1. If |parsedType|'s [=MIME type/type=] is "*", return `true`. | |||
| 1. If |parsedType|'s [=MIME type/type=] is |type|'s [=MIME type/type=], return `true`. | |||
| 1. |parsedType|'s [=MIME type/essence=] is |type|'s [=MIME type/essence=], return `true`. | |||
| 1. If |extensions| is a string, set |extensions| to a [=list=] with a single | |||
| 1. If |extensions| is a string, set |extensions| to a [=/list=] with a single | |||
There was a problem hiding this comment.
This could use the fancy « |extensions| » syntax, but this is fine as is.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 18, 2020
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 19, 2020
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 19, 2020
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 19, 2020
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Cr-Commit-Position: refs/heads/master@{#799857}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 20, 2020
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Cr-Commit-Position: refs/heads/master@{#799857}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 27, 2020
…ectory to StorageManager., a=testonly Automatic update from web-platform-tests [FS] Move and rename getOriginPrivateDirectory to StorageManager. Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Cr-Commit-Position: refs/heads/master@{#799857} -- wpt-commits: 520cb04052be2698ef2abe0eb22661299150f9bb wpt-pr: 25081
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
…ectory to StorageManager., a=testonly Automatic update from web-platform-tests [FS] Move and rename getOriginPrivateDirectory to StorageManager. Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Cr-Commit-Position: refs/heads/master@{#799857} -- wpt-commits: 520cb04052be2698ef2abe0eb22661299150f9bb wpt-pr: 25081
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Renames self.getOriginPrivateDirector() to navigator.storage.getDirectory(), following the changes in WICG/file-system-access#217. Change-Id: Ie993c24b56ffdf369bb87ed03eb786f458e50ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363567 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Joshua Bell <[email protected]> Cr-Commit-Position: refs/heads/master@{#799857} GitOrigin-RevId: f2ec95138c4a40c62ea5749bb2227e670866756f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
self.getOriginPrivateDirector()tonavigator.storage.getDirectory().Fixes #211.
Preview | Diff