Mention the risk of filling up the disk in the security considerations. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also be explicit in the "write" and "truncate" steps that these operations can fail with a QuotaExceededError if the file would be too big. Fixes #277
Closed
1 task
a-sully
approved these changes
Feb 16, 2021
|
|
||
| Note: [=Storage quota=] only applies to files stored in the [=origin private file system=]. | ||
| However this operation could still fail for other files, for example if the disk being written | ||
| to runs out of disk space. |
There was a problem hiding this comment.
Should we link to the new "Filling up a users disk" section here? (and below at line 1030)
There was a problem hiding this comment.
Not sure, they are kind of separate (but related) things, I don't think linking there from here really adds much.
Co-authored-by: Austin Sullivan <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Feb 18, 2021
…ty considerations. (#278) * Mention the risk of filling up the disk in the security considerations. Also be explicit in the "write" and "truncate" steps that these operations can fail with a QuotaExceededError if the file would be too big. Fixes #277 * Update index.bs Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> SHA: e74baf7 Reason: push, by @mkruisselbrink Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also be explicit in the "write" and "truncate" steps that these
operations can fail with a QuotaExceededError if the file would be too
big.
Fixes #277
Preview | Diff