Editorial: Use more precise exceptions #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
requested changes
Jun 15, 2023
index.bs
Outdated
| @@ -322,7 +325,7 @@ should be treated by the user agent as the user intending to grant read access t | |||
| for the returned files. As such, at the time the promise returned by one of the [=local file system handle factories=] | |||
| resolves, [=permission state=] for a descriptor with {{FileSystemPermissionDescriptor/handle}} set to the returned handle, | |||
| and {{FileSystemPermissionDescriptor/mode}} set to {{"read"}} | |||
| should be {{PermissionState/"granted"}}. | |||
| should be {{PermissionState/granted}}. | |||
There was a problem hiding this comment.
We still want quotes, just around the whole thing i.e. "{{PermissionState/granted}}"
There was a problem hiding this comment.
Apologies, I was considering making this change (to address whatwg/fs#133) in this PR and then decided to leave it for a follow-up... but incorrectly undo-ed my changes 🤦
I'll send a follow-up with these changes
inexorabletash
requested changes
Jun 20, 2023
inexorabletash
approved these changes
Jun 20, 2023
github-actions bot
added a commit
that referenced
this pull request
Jun 20, 2023
Before: `throw a {{SecurityError}}`
After: `[=throw=] a "{{SecurityError}}" {{DOMException}}`
See whatwg/fs#63 and whatwg/fs#89. Fixed in the upstream spec in whatwg/fs#70 and whatwg/fs#91, respectively
SHA: a350a87
Reason: push, by @a-sully
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
a-sully
added a commit
that referenced
this pull request
Jun 20, 2023
Before: `{{PermissionState/"granted"}}`
After: `"{{PermissionState/granted}}"`
See whatwg/fs#133. Also called out here: #417 (comment)
github-actions bot
added a commit
that referenced
this pull request
Jun 20, 2023
Before: `{{PermissionState/"granted"}}`
After: `"{{PermissionState/granted}}"`
See whatwg/fs#133. Also called out here: #417 (comment)
SHA: 44df0c4
Reason: push, by @a-sully
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
throw a {{SecurityError}}After:
[=throw=] a "{{SecurityError}}" {{DOMException}}See whatwg/fs#63 and whatwg/fs#89. Fixed in the upstream spec in whatwg/fs#70 and whatwg/fs#91, respectively
Preview | Diff