-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic & API outline #23
Merged
Merged
+636
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note RFC 2119 terminology usage expectations - Define some reusable key terms, reference them - Add the initial boilerplate for abstract operations: "When asked to ..." - Clarify user's consent and privacy requirements
- Align constructor argument names with convention when inheriting from EventTarget - Add missing onerror entry to LP2PDataChannel events table - Tweak the "The following are the event handlers" boilerplates (Bikeshed handles the plural form in <a>s) - Change from "dispatched" to "fired" (Fire is short for create, initialize, and dispatch: https://dom.spec.whatwg.org/#firing-events) - Make LP2PConnectionEvent a CustomEvent, inherit from Event, note some caveats: https://dom.spec.whatwg.org/#interface-customevent - Remove redundant 'when's from Events tables
anssiko
approved these changes
Nov 29, 2023
wangw-1991
reviewed
Nov 30, 2023
anssiko
reviewed
Dec 4, 2023
Co-authored-by: Anssi Kostiainen <[email protected]>
This was referenced Dec 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first outline for logic and API. It is not meant to be all-encompasing yet, just a step in the right (hopefully) direction.
Design considerations
Receiver
andRequest
objects is inspired by the Presentation API.async
API for theReceiver
andRequest
where needed. I kept theDataChannel API
close/equivalent to it's WebRTC counterpart. (relates to #14).Preview | Diff