Introspection of Sanitizer configs (and default config). #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfc0d886f2a6ef32b074f0e81689f296891e06a9 git squash commit for introspection. a9bad05925e88419d5cf5dd43a0514d262090fcf wip 4f71d76d8c43898cd2685e0cb4086b4074f787b3 wip 34fe037326dbb851132cc65462fa41a6acd57e06 Continue. Dictionaries can't be attributes.
mozfreddyb
reviewed
Apr 20, 2021
index.bs
Outdated
|
|
||
| // We found a Sanitizer instance. Does it have an allow-list configured? | ||
| const a_sanitizer = ...; | ||
| !!a_sanitizer.config().allowElements // true, iff an allowElements list is configured |
There was a problem hiding this comment.
Nit: I'd spell "iff" out (or just use "if") :)
| as its [=configuration object=]. | ||
| * The <dfn method for=Sanitizer><code>sanitize(<var>input</var>)</code></dfn> | ||
| method steps are to return the result of running the [=sanitize=] | ||
| algorithm on |input|, | ||
| * The <dfn method for=Sanitizer><code>sanitizeToString(<var>input</var>)</code></dfn> | ||
| method steps are to return the result of running [=sanitizeToString=] | ||
| algorithm on |input|. | ||
| * The <dfn method for=Sanitizer><code>config()</code></dfn> method steps are | ||
| to return the result of running the [=query the sanitizer config=] | ||
| algorithm. It essentially returns a copy of the Sanitizer's |
There was a problem hiding this comment.
Should this sentence be marked as non normative?
There was a problem hiding this comment.
Yeah. I solved this by removing the sentence, and instead adding an example which compares the two. That way, normativity is clear, and we gain a free example. :-)
iVanlIsh
approved these changes
Apr 20, 2021
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Ref: WICG/sanitizer-api#80 Bug: 1202655 Change-Id: I743cedadab7e89bcce6b8248fd299a70c8164c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874605 Commit-Queue: Daniel Vogelheim <[email protected]> Reviewed-by: Yifan Luo <[email protected]> Cr-Commit-Position: refs/heads/master@{#879407} NOKEYCHECK=True GitOrigin-RevId: 31650c7aae8745e581fc625e93f3bdaa73b8753f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: Allow introspection of Sanitizers' configuration. (#77)