Add TaskSignal.any() #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds TaskSignal.any(), which builds off of the algorithms being added for AbortSignal.any(). Unlike the abort component, each composite TaskSignal can have only one parent (for priority). This does a similar optimization in that dependent signals are put on non-composite nodes.
|
@domenic would you mind reviewing this too? It mirrors the |
This reverts commit 1e87841.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specialization of
AbortSignal.any()for TaskSignal.any(). It supports creating a composite signal with multiple abort sources and either a fixed priority or single priority source. The spec is similar toAbortSignal.any()and uses the internal constructor for the abort aspect.Tests: https://github.com/web-platform-tests/wpt/tree/master/scheduler (task-signal-any*).
Preview | Diff