use bucket map & update persist() #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayuishii
changed the title
ayuishii
changed the title
ayuishii
added a commit
that referenced
this pull request
Mar 16, 2023
* Add IndexedDB text. (#46) * Updates around user visibility of buckets. * Add self as author. * Clarify wording. * Add bucket durability and IndexedDB text. * algorithm tag Co-authored-by: Evan Stade <[email protected]> * Add caches and getDirectory text. (#51) Co-authored-by: Evan Stade <[email protected]> * Creating a bucket (#48) * Spec for creating a bucket * fix english * Address comments * Algorithms for delete (#50) * Fix bad merge * Algorithm for keys() (#52) * Add caches and getDirectory text. (#47) * Updates around user visibility of buckets. * Add self as author. * Clarify wording. * Add bucket durability and IndexedDB text. * algorithm tag * caches and getDirectory * remove abbreviation Co-authored-by: Evan Stade <[email protected]> * Revert "Add caches and getDirectory text. (#47)" (#49) This reverts commit a2fa5bc. * Algorithm for keys() * fix append Co-authored-by: Evan Stade <[email protected]> Co-authored-by: Evan Stade <[email protected]> * spec-draft rebase (#53) * Add caches and getDirectory text. (#47) * Updates around user visibility of buckets. * Add self as author. * Clarify wording. * Add bucket durability and IndexedDB text. * algorithm tag * caches and getDirectory * remove abbreviation Co-authored-by: Evan Stade <[email protected]> * Revert "Add caches and getDirectory text. (#47)" (#49) This reverts commit a2fa5bc. Co-authored-by: Evan Stade <[email protected]> Co-authored-by: Evan Stade <[email protected]> * Enhance IDB, CacheStorage algorithms. (#54) * Enhance IDB, CacheStorage algorithms. Also distinguish between the conceptual bottle and the StorageBottle object in the open() definition. * algo tags Co-authored-by: Evan Stade <[email protected]> * Add more algorithms for StorageBucket attributes. (#55) * Add more algorithms for StorageBucket attributes. * reference StorageEstimate object Co-authored-by: Evan Stade <[email protected]> * Enhancements. (#56) * Enhancements. 1. Specify when expired buckets are removed. 2. Improve some text around durability, quota. * fix some link errors * or equal to * Review updates Co-authored-by: Evan Stade <[email protected]> * Write persist/persisted algos (#57) * Write persist/persisted algos * no backticks on true Co-authored-by: Evan Stade <[email protected]> * Fill in some error types. (#58) * Write persist/persisted algos * no backticks on true * Fill in some error types. * Indentation fixes * Fix redundant step. * Streamline delete bucket. Co-authored-by: Evan Stade <[email protected]> * Add Clear Site Data. (#59) * Add Clear Site Data. Most of this text needs to be worked into various parts of the CSD spec. * Better annotations Co-authored-by: Evan Stade <[email protected]> * Address review feedback (#63) Co-authored-by: Evan Stade <[email protected]> * Spec draft (#64) * Address review feedback * additional review comment --------- Co-authored-by: Evan Stade <[email protected]> * Spec draft (#65) * Address review feedback * additional review comment --------- Co-authored-by: Evan Stade <[email protected]> * Spec draft (#66) * Address review feedback * additional review comment --------- Co-authored-by: Evan Stade <[email protected]> * fix typo (#67) Co-authored-by: Evan Stade <[email protected]> * Address comments (#68) * Use TypeError * Update index.bs * null or undefined * s/and/, then/ * backticks instead of <code> * Address comments #2 (#69) * durability value * quota value * expiration value * Address comments 3 (#70) * quota value in bytes * code point * Operate open bucket on storage bucket map * use bucket map & update persist() (#71) * Expand usage of bucket map * remove the * Use bucket map for clear site data * short-circuit if bucket is already persistent * Update time & expiration (#72) * Update time * Update time 2 * check for null bucket expiration * parse duration string * Fix link to html spec * make durability() not async (#73) * Address comments (#74) * Update to use TypeError instead of UnknownError * Remove obtaining |storageKey| * Fix parallel steps * Fix dfn for storage usage * Fix parallel steps for keys() & delete() * Fix delete() * Handle undefined quota * Use wall time * UA bucket clearing wording * Add bucket to bucket map on creation * Fix indent * Add algorithm for bucket removal (#75) * Add algorithm for bucket removal * Update index.bs * update algorithms with remove * Fix wording * Fix wording #2 * Add issues for storage endpoint quota eviction (#77) * Address comments (#78) * Address comments * Fix bucket removal step * Add Service Worker deletion to issue * Remove string parsing step for expires * Update duration to moment * get or expire a bucket * Allow UA bucket deletion on expiration * Nit * Apply suggestions by @jyasskin Co-authored-by: Jeffrey Yasskin <[email protected]> * Update expiration (#80) * expiration time * Specify moment on the wall clock * Use [=Unix epoch=] * Mark -> set * Fix expiration comparison * Apply jyasskin@'s suggestions Use "before" instead of "less than or equal" Co-authored-by: Jeffrey Yasskin <[email protected]> * Use queue a task (#81) * Use [=queue a task=] * Additional changes * Update persist() and add note on Promises (#82) * Fix persist() to not reference [=this=] in parallel steps * Note on promises --------- Co-authored-by: Evan Stade <[email protected]> Co-authored-by: Ayu Ishii <[email protected]> Co-authored-by: Jeffrey Yasskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff