chore: refactor custom header implementation #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
huijing
commented
Oct 9, 2023
| @@ -212,12 +213,6 @@ export default defineConfig({ | |||
| react(), | |||
| astroI18next(), | |||
| ], | |||
| // Process images with sharp: https://docs.astro.build/en/guides/assets/#using-sharp | |||
There was a problem hiding this comment.
We are not running our images through the sharp pipeline.
huijing
commented
Oct 9, 2023
| @@ -1,22 +1,19 @@ | |||
| --- | |||
| import type { Props } from '@astrojs/starlight/props'; | |||
There was a problem hiding this comment.
This is the official method of doing Starlight component override, see https://starlight.astro.build/guides/overriding-components/ for documentation.
sabineschaller
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398
This PR removes the previous custom header implementation files, and bumps dependencies to the latest version.