Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created angular-free version of committees page #100

Merged
merged 5 commits into from
Sep 25, 2015
Merged

Created angular-free version of committees page #100

merged 5 commits into from
Sep 25, 2015

Conversation

jgadelange
Copy link
Member

Work on #50

@praseodym
Copy link
Member

Looking good, paar issues:

  • Data is niet gesorteerd: zou bestuursjaar->commissie->naam moeten worden
  • Queries duren op m'n laptop maar 100ms, alleen pagina renderen duurt 3500ms. Pagination, of filter verplicht maken?
  • Commissie toevoegen kan niet (kon eerst ook niet), los issue voor maken?

@jgadelange
Copy link
Member Author

Sorteren zal ik inderdaad even toevoegen.

Pagination kan relatief makkelijk toegevoegd worden op view niveau (je zet gewoon paginate_by=20 en het werkt), maar is erg onhandig in de templates. Ik kon zo snel niet dé manier vinden om de querystring mee te nemen in een linkje.

Commissie toevoegen inderdaad maar even losse issue denk ik.

@jgadelange
Copy link
Member Author

Alles toegevoegd 😄

praseodym
praseodym reviewed Sep 25, 2015
View reviewed changes
dienst2/settings.py
@@ -83,6 +83,21 @@
'django.template.loaders.app_directories.Loader',
)

TEMPLATES = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waar is dit voor nodig?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

om 1 of andere reden kon ik in de templates niet request.META benaderen ofzo, dus toen heb ik dit toegevoegd.

Als je vraagt waarom het tegenwoordig in een TEMPLATES variable zit, dat is omdat je makkelijker je template renderer kan wisselen sinds django 1.8, dus je kan ook per template backend andere settings hebben.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright :)

praseodym added a commit that referenced this pull request Sep 25, 2015
@praseodym
Merge pull request #100 from WISVCH/fb-master_committees
1c0f5cb 
Created angular-free version of committees page
@praseodym praseodym merged commit 1c0f5cb into master Sep 25, 2015
@praseodym praseodym deleted the fb-master_committees branch September 25, 2015 09:19
@praseodym praseodym mentioned this pull request Sep 25, 2015
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@praseodym praseodym

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgadelange @praseodym