-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgERA5 download script #311
Conversation
Hi @krsnapaudel, Thank you for using my script. here is my review and some enhancements that make it clearer and easier to follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was nice to reivew the written code, and I hope this review will be valuable. Thank you.
@AbdelrahmanAmr3: Please review again. Thanks. |
@ellaampy Would you be willing to try this out and provide feedback or approve? Thanks. |
@krsnapaudel the logic looks fine. I followed the instructions to create a token and tried to run for a single year. Got this error |
@ellaampy Did you accept the license terms for AgERA5? |
@krsnapaudel you're right. I missed that. now it is running. I'll let it continue and see if any files are downloaded |
@ellaampy Have you tested this? If so, could you approve? Thanks. |
Download full rasters, without bounding boxes. This is to maintain an up-to-date repository that can produce data for new countries. After this the R script in #199 does not need a special case for AgERA5 paths. See #308.
The code is derived from @AbdelrahmanAmr3's earthstat.