Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgERA5 download script #311

Merged
merged 19 commits into from
Nov 26, 2024
Merged

AgERA5 download script #311

merged 19 commits into from
Nov 26, 2024

Conversation

krsnapaudel
Copy link
Collaborator

@krsnapaudel krsnapaudel commented Aug 22, 2024

Download full rasters, without bounding boxes. This is to maintain an up-to-date repository that can produce data for new countries. After this the R script in #199 does not need a special case for AgERA5 paths. See #308.

The code is derived from @AbdelrahmanAmr3's earthstat.

@krsnapaudel krsnapaudel self-assigned this Aug 22, 2024
@AbdelrahmanAmr3
Copy link
Collaborator

Hi @krsnapaudel, Thank you for using my script. here is my review and some enhancements that make it clearer and easier to follow.

Copy link
Collaborator

@AbdelrahmanAmr3 AbdelrahmanAmr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was nice to reivew the written code, and I hope this review will be valuable. Thank you.

data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
data_preparation/global_AgERA5/download_agera5.py Outdated Show resolved Hide resolved
@krsnapaudel
Copy link
Collaborator Author

@AbdelrahmanAmr3: Please review again. Thanks.

@krsnapaudel krsnapaudel requested a review from ellaampy November 19, 2024 13:12
@krsnapaudel
Copy link
Collaborator Author

@ellaampy Would you be willing to try this out and provide feedback or approve? Thanks.

@ellaampy
Copy link
Collaborator

@krsnapaudel the logic looks fine. I followed the instructions to create a token and tried to run for a single year. Got this error Recovering from connection error [HTTPSConnectionPool(host='cds.climate.copernicus.eu', port=443): Max retries exceeded with url: /api/catalogue/v1/messages (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f1b48687640>, 'Connection to cds.climate.copernicus.eu timed out. (connect timeout=60)'))], attemps 1 of 500 Retrying in 120 seconds

@krsnapaudel
Copy link
Collaborator Author

@ellaampy Did you accept the license terms for AgERA5?

@ellaampy
Copy link
Collaborator

@krsnapaudel you're right. I missed that. now it is running. I'll let it continue and see if any files are downloaded
image

@krsnapaudel
Copy link
Collaborator Author

@ellaampy Have you tested this? If so, could you approve? Thanks.

@ellaampy ellaampy merged commit e5fa8ff into main Nov 26, 2024
4 checks passed
@krsnapaudel krsnapaudel deleted the krsnapaudel/agera5 branch November 27, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants