Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Mass Bug Fix #130

Merged
merged 10 commits into from
Nov 24, 2024
Merged

[Fix] Mass Bug Fix #130

merged 10 commits into from
Nov 24, 2024

Conversation

Spatison
Copy link
Member

@Spatison Spatison commented Nov 23, 2024 •
edited
Loading

Описание PR

Исправил много багов с багрепортов. Также порт Simple-Station/Einstein-Engines#1256

Изменения

🆑 Spatison

  • fix: Массовый баг фикс

sleepyyapril and others added 6 commits November 22, 2024 17:10
@sleepyyapril @Spatison
Mass Bug Fixing (#1256)
fd3c8ae 
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Mass bug fixing, for bugs related to #1220.
Feel free to link or send bugs.

Fix list:
- #1242
- #1243
- #1244
- space-wizards/space-station-14#28084
- space-wizards/space-station-14#28282
- Actually fixed PirateRadioSpawnRule heisentest (with a bandaid) (I
cancel if it's 0)
- Simple-Station/Einstein-Engines#1263

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed chair visuals drawing depth wrongly if you sat in a
north-facing chair.
- fix: Fixed buckling doing several buckles each time you did one.
- fix: Fixed the magic mirror.
- fix: Fixed beds re-positioning you every few seconds.
- fix: Fixed E not opening containers that are in another container.
- fix: Fixed disposal systems not flushing or ejecting properly.

---------

Co-authored-by: sleepyyapril <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>
Co-authored-by: Nemanja <[email protected]>
(cherry picked from commit 41501bd335c5e1e2e65b5d2ad040a3ae6851d4e8)
@SimpleStation14 @Spatison
Automatic Changelog Update (#1256)
334b5c4 
(cherry picked from commit 9798f5363135cbe71479d0a14cf3215d01ed28f0)
@Spatison
fix
f467282
@PJB3005 @Spatison
Fix animation looping bugs. (#29457)
425a90b 
Summary of the problem is in the corresponding engine commit: space-wizards/RobustToolbox@a4ea5a4

This commit requires engine master right now.

I think #29144 is probably the most severe one, but I touched Jittering and RotatingLight too since they seemed sus too.

Fixes #29144

Co-authored-by: metalgearsloth <[email protected]>
(cherry picked from commit 8d015f5c9ff60107dccdf35fa48e1558728ff269)
@themias @Spatison
Fix arcade machines (#30376)
68e67e8 
(cherry picked from commit e72393df712cb2f5d1b4f6b4e2dc417c5584f07a)
@Spatison
fix
2501074
@Spatison Spatison requested a review from Remuchi November 23, 2024 15:32
@Spatison Spatison self-assigned this Nov 23, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2024 •
edited
Loading

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between ec0cbe6 and b402f14.

📒 Files selected for processing (42)
  • Content.Client/Arcade/BlockGameMenu.cs (1 hunks)
  • Content.Client/Buckle/BuckleSystem.cs (1 hunks)
  • Content.Client/Jittering/JitteringSystem.cs (1 hunks)
  • Content.Client/Light/EntitySystems/LightBehaviorSystem.cs (1 hunks)
  • Content.Client/Light/EntitySystems/RotatingLightSystem.cs (1 hunks)
  • Content.Client/Salvage/UI/SalvageMagnetBoundUserInterface.cs (1 hunks)
  • Content.Client/_White/Animations/WaddleAnimationSystem.cs (2 hunks)
  • Content.Server/Arcade/BlockGame/BlockGame.Ui.cs (2 hunks)
  • Content.Server/Construction/Components/WelderRefinableComponent.cs (1 hunks)
  • Content.Server/Disposal/Tube/DisposalTubeSystem.cs (1 hunks)
  • Content.Server/Disposal/Unit/EntitySystems/DisposableSystem.cs (4 hunks)
  • Content.Server/Disposal/Unit/EntitySystems/DisposalUnitSystem.cs (1 hunks)
  • Content.Server/MagicMirror/MagicMirrorSystem.cs (5 hunks)
  • Content.Server/PowerCell/PowerCellSystem.cs (1 hunks)
  • Content.Server/Silicon/WeldingHealable/WeldingHealableSystem.cs (1 hunks)
  • Content.Server/StationEvents/Events/PirateRadioSpawnRule.cs (4 hunks)
  • Content.Server/_White/Animations/WaddleAnimationSystem.cs (0 hunks)
  • Content.Shared/Body/Systems/SharedBodySystem.Body.cs (4 hunks)
  • Content.Shared/Body/Systems/SharedBodySystem.Parts.cs (2 hunks)
  • Content.Shared/Buckle/Components/BuckleComponent.cs (4 hunks)
  • Content.Shared/Buckle/Components/StrapComponent.cs (1 hunks)
  • Content.Shared/Buckle/SharedBuckleSystem.Buckle.cs (3 hunks)
  • Content.Shared/Buckle/SharedBuckleSystem.Interaction.cs (1 hunks)
  • Content.Shared/Buckle/SharedBuckleSystem.Strap.cs (1 hunks)
  • Content.Shared/CCVar/CCVars.cs (1 hunks)
  • Content.Shared/Doors/Systems/SharedDoorSystem.cs (1 hunks)
  • Content.Shared/Interaction/SharedInteractionSystem.cs (1 hunks)
  • Content.Shared/MagicMirror/MagicMirrorComponent.cs (1 hunks)
  • Content.Shared/MagicMirror/SharedMagicMirrorSystem.cs (3 hunks)
  • Content.Shared/Mobs/Systems/MobStateSystem.Subscribers.cs (1 hunks)
  • Content.Shared/Movement/Components/WaddleAnimationComponent.cs (0 hunks)
  • Content.Shared/Standing/StandingStateSystem.cs (3 hunks)
  • Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs (0 hunks)
  • Content.Shared/_White/Animations/SharedWaddleAnimationSystem.cs (1 hunks)
  • Resources/Changelog/Changelog.yml (2 hunks)
  • Resources/Locale/ru-RU/traits/traits.ftl (1 hunks)
  • Resources/Prototypes/Entities/Clothing/Eyes/glasses.yml (1 hunks)
  • Resources/Prototypes/Entities/Structures/Furniture/rollerbeds.yml (0 hunks)
  • Resources/Prototypes/Entities/Structures/Piping/Disposal/units.yml (1 hunks)
  • Resources/Prototypes/Entities/Structures/Wallmounts/mirror.yml (1 hunks)
  • Resources/Prototypes/Entities/Structures/plastic_flaps.yml (0 hunks)
  • Resources/Prototypes/_White/tags.yml (1 hunks)
 ____________________________________________________
< It's dangerous to go alone! Take this code review. >
 ----------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting in your project's settings in CodeRabbit to disable the changed files summary in the walkthrough.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Spatison
Copy link
Member Author

Драйдок срет в тесты

@Remuchi Remuchi merged commit 2fd69f5 into master Nov 24, 2024
9 of 10 checks passed
@Remuchi Remuchi deleted the bugfix branch November 24, 2024 18:20
TokiJumper referenced this pull request in TokiJumper/wwdpublic Nov 28, 2024
@riddleridou
Automatic Changelog Update (#130)
b2fc4ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Remuchi Remuchi Remuchi approved these changes

Assignees

@Spatison Spatison

Labels
Changes: C# Changes: Localization Changes: YML Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Spatison @Remuchi @sleepyyapril @SimpleStation14 @PJB3005 @themias