Win32Exception Regression and others #169
Conversation
Quick fix for regression found in handling of Win32Exception. Since Win32Exception is unchecked exception and due to number of callers, rethrow this as IOException as is.
Add final keywords. Enhance for loop by externalizing string creation. Return group name in one call rather than creating string and then returning a portion of it.
Updated changelog for special release. Set pom to waffle 1.7 parent and 1.7.1 for release patch of waffle-jna.
|
This build will fail. This is because the remainder of the multi module stack is versioned differently. Building it separately does pass without issue. I"m suggesting that we push this one-time release which will address two separate issues. Oddly enough, my commit at this moment caused the build to appear successful but looking at it clearly shows it is not. I think it just stopped the process. Anyway, still safe here. I also used the REPO/compare option to compare against the final cuts that went out for 1.7 to see what all was in waffle-jna since and reflected that in the release notes as 1.7.1 release. |
fixed so links to issues on 1.7.1 work.
need version to say snapshot for release.
|
I pushed this out to snapshots -> https://oss.sonatype.org/content/repositories/snapshots/com/github/dblock/waffle/waffle-jna/1.7.1-SNAPSHOT/ Provided user feedback is good I can release this tomorrow evening. I was sort of hoping this would solve other Win32 errors with tokens that I see but no such luck. However, this seems to point in a general direction so I will start looking at that again. In general while not fun issues, I do not think either the base64 issue or this one poses a huge problem. Both are workable if not likable. |
|
I think this definitely needs a test before someone undoes the try/catch and puts back a Win32Exception because they don't understand why this happens. |
Win32Exception Regression and others
Quick patch to resolve regression with Win32Exception issue on logon per issue #168.
Small number of other items and prepartion for releasing this.
Please note: I believe we agree we need some specialized exceptions. In order to do so, additional time is needed to review how things are currently working. For now, it seems best to do a quick release of waffle-jna as 1.7.1 to patch this issue.