Upgrade to Java 8 - using caffeine #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazendaz
reviewed
Jan 28, 2017
| @@ -202,6 +202,8 @@ | |||
| <configuration> | |||
| <!-- Slightly faster builds, see https://issues.apache.org/jira/browse/MCOMPILER-209 --> | |||
| <useIncrementalCompilation>false</useIncrementalCompilation> | |||
| <source>1.8</source> | |||
There was a problem hiding this comment.
One change. If you go up to properties, you will see the java version settings there. Those control it across the board, so please set it there. Otherwise, I'm blown away. I didn't expect such a quick response or realize just quite how easy this was. So thank you so very much!
here is what should be changed instead for compiler.
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
<maven.compiler.testSource>1.7</maven.compiler.testSource>
<maven.compiler.testTarget>1.7</maven.compiler.testTarget>
All to 1.8 works.
There was a problem hiding this comment.
Thanks. I assume this is signature.artifact is Animal Sniffer? Upgraded it as well.
<signature.artifact>java18</signature.artifact>
There was a problem hiding this comment.
cool thanks. you have sparked a fire. I'm going to go ahead and start on 1.9. I aleady had a 1.8.x branch saved off so I'll just cherry pick for needs over there. Appreciate it very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the compiler to 1.8 (defaults to 1.5). This does not change code patterns, as still valid and style is a team choice. Switched from Guava's cache to Caffeine as requested.