Skip to content

Commit

Permalink
fixing json compiler and updating uglify-js version and associated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Fitzgerald committed Jul 14, 2012
1 parent ffd8e4c commit 5d6492f
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 23 deletions.
6 changes: 3 additions & 3 deletions examples/src/js/app.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
var $ = require('jquery'),
backbone = require('backbone'),
template = require('templates/world'),
hbarsTemplate = require('templates/hello'),
hbarsTemplate = require('./templates/hello'),
name = require("./foo").name,
myconfig = require("./myconfig");
config = require("./config");

console.log("foo's name is.....", name);
console.log("backbone version is", backbone.VERSION);
console.log("Config variable some_key: " + myconfig.some_key);
console.log("Config is: " + JSON.stringify(config));

exports.app = {
foo : "moar...",
Expand Down
12 changes: 3 additions & 9 deletions lib/assembly/compilers/json.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ var utile = require('utile');
exports.name = "json compiler";
exports.mimeType = "application/javascript";

var JsonCompiler = exports.JsonCompiler = function(options) {
this.options = options;
};

JsonCompiler.prototype.compile = function(file, data, cb) {
exports.compile = function(file, data, cb) {
try {
var result = "module.exports =" + JSON.stringify(JSON.parse(data));
cb(null, result);
Expand All @@ -17,9 +13,7 @@ JsonCompiler.prototype.compile = function(file, data, cb) {
};

exports.attach = function (options) {
var compilerOptions = utile.mixin({}, options);
var compiler = new JsonCompiler(compilerOptions);

var worker = this.worker;
worker.registerCompiler(".json", compiler);

worker.registerCompiler(".json", module.exports);
};
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "http://www.apache.org/licenses/LICENSE-2.0"
}
],
"keywords": ["client", "templates", "handlebars", "middleware","flatiron", "web"],
"keywords": ["client", "backbone", "templates", "handlebars", "middleware", "web"],
"dependencies": {
"broadway" : "0.1.x",
"less" : "1.3.x",
Expand All @@ -24,21 +24,22 @@
"read-dir-files" : "0.1.x",
"detective" : "~0.1.0",
"resolve" : "0.1.x",
"uglify-js" : "1.2.x",
"uglify-js" : "1.3.x",
"traverse" : "0.6.x",
"optimist" : "0.3.x"
},
"devDependencies": {
"mocha" : "1.3.x",
"should": "0.6.x",
"coffee-script" : "1.2.x",
"coffee-script" : "1.3.x",
"handlebars" : "1.0.x",
"underscore" : "1.3.x",
"express" : "2.5.x"
},
"bin": { "assembly": "./bin/assembly" },
"scripts": {
"test" : "make test"
"test" : "make test",
"start" : "node examples/server.js"
},
"engines": { "node": ">= 0.6.0" },
"main": "./lib/assembly"
Expand Down
6 changes: 2 additions & 4 deletions test/compilers/json-test.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
var TestHelper = require("../test-helper"),
JsonCompiler = require("../../lib/assembly/compilers/json").JsonCompiler,
JsonCompiler = require("../../lib/assembly/compilers/json"),
util = require('util'),
should = require('should'),
fs = require("fs"),
path = require('path');

describe("JsonCompiler", function() {
var compiler;
beforeEach(function(){
var app = TestHelper.mockApp();
compiler = new JsonCompiler();
});

describe("Compile", function(){
it('should only have dev variables', function(done) {
compiler.compile(TestHelper.jsRoot + "/config.json", TestHelper.fixture("/js/config.json"), function(err, data) {
JsonCompiler.compile(TestHelper.jsRoot + "/config.json", TestHelper.fixture("/js/config.json"), function(err, data) {
should.not.exist(err);

data.should.include('def');
Expand Down
4 changes: 4 additions & 0 deletions test/fixtures/amd/coffee_in.coffee
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
$ = require('jquery');

exports =
foo: "bar"
2 changes: 2 additions & 0 deletions test/fixtures/amd/coffee_out.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/fixtures/amd/coffee_out_expected.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
define("amd/coffee_out", [ "require", "module", "exports", "jquery" ], function(require, module, exports) {
((function() {
(function() {
var $, exports;
$ = require("jquery");
exports = {
foo: "bar"
};
})).call(this);
}).call(this);
});
2 changes: 1 addition & 1 deletion test/processors/amdify-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe("Amdify Processor", function() {
var src = amdify.process(TestHelper.testSrcDir +"/app.js", foo);
src.should.eql(TestHelper.fixture("amd/expected.js"));
done();
});
});

it("should amdify coffeescript compiled code", function(done) {
var coffee = TestHelper.fixture("/amd/coffee_out.js");
Expand Down

0 comments on commit 5d6492f

Please sign in to comment.