Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deltaf fixes #1

Open
wants to merge 13 commits into
base: 4.18-devel
Choose a base branch
from
Open

Deltaf fixes #1

wants to merge 13 commits into from

Conversation

keithbennett
Copy link
Contributor

In GitLab by Ben McMillan (@benmcmillanwarwick) on 26 Apr 2018, 10:58 (GitLab merge request GL#111)

Up to 81d3f1f6, this branch just contains bug fixes, so this is what should be merged.

More recent commits include a two-temperature loading designed to improve resolution of tails of the distribution: useful for deltaf potentially. Not sure this should be merged though... I think Chris' work may have similar functionality.

keithbennett and others added 13 commits June 27, 2018 00:33
 while using DELTAF_METHOD

-DELTAF_METHOD requires PER_SPECIES_WEIGHT (needs fix)

-Housekeeping message for DELTAF_METHOD
-Show whether code has been compiled with DELTAF_METHOD in welcome screen.
…uld now

 work correctly whether or not PER_SPECIES_WEIGHT is set.
…eltaf calculation. Fixes some crashes when only some species use deltaf.

-Fix a bug related to PER_PARTICLE_CHARGE_MASS

-f0 in particles.f90 used in loading routine when debugging: update dependencies.

-Most of the changes in deltaf_loader are to allow 'Two-temperature' loading: half the markers are loaded with a maxwellian distribution of one temperature, half with a higher temperature (proportion and ratio T1/T2 hard coded at the moment). The weights of the markers are adjusted appropriately so the particle distribution function f is a standard maxwellian (the marker distribution function g is not).

This is potentially useful for better resolving the tails of the distribution function, for cases where only the tail is energised. It is also useful in deltaf calculations because it helps to ensure good sampling of phase space even if markers are scattered strongly in energy.

-Two-temperature loading is turned on according to whether the species name ends with _2t: to be modified.
…eful for deltaf

 runs, where phase space sampling needs to remain sufficient during simulation.
@keithbennett keithbennett added this to the 4.18 milestone Feb 12, 2021
@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 18 Jun 2018, 22:01

changed the description

@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 18 Jun 2018, 22:01

changed target branch from devel to 4-devel

@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 18 Jun 2018, 22:40

changed target branch from 4-devel to 4.14-devel

@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 29 Jun 2018, 09:06

added 226 commits

  • 62ff5903...68a54e3f - 213 commits from branch 4.14-devel
  • 03058c8 - Uppercase FORTRAN keywords
  • 7dbc8a6 - -Bug fixes for delta-f version: add ability to set temperatures zero
  • 7744f32 - -Fix bug in f0 calculation in deltaf particle load.
  • 7699d82 - Distribution function output: deltaf distribution function option should now
  • 69881e9 - -Only load weights in deltaf loading routine if particle marked for deltaf…
  • 12e6c43 - -Add option to allow for phase space volume information in output: useful for deltaf
  • 985471b - Remove trailing whitespace
  • 85bad0e - Tidied code
  • 5629fac - Fixed array bounds errors
  • 4715fc1 - Moved delta-f loading routines to end of module
  • de2be8e - Moved #ifdefs to surround all delta-f additions
  • 31e5908 - Fixed compiler warnings
  • 699a0dd - Ported changes across to epoch2d/3d

Compare with previous version

@keithbennett
Copy link
Contributor Author

In GitLab by Heather Ratcliffe (@hratcliffe) on 28 Sep 2018, 13:55

I have some additional tiny fixes and I think I've fixed up the thermal boundaries. Shall I push changes here once they're done?

@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 11 Mar 2019, 08:10 UTC

changed target branch from 4.14-devel to 4.17-devel

@keithbennett
Copy link
Contributor Author

In GitLab by Keith Bennett (@keithbennett) on 03 Jun 2019, 15:11

changed target branch from 4.17-devel to 4.18-devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant