Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip location #113

Merged
merged 5 commits into from
Nov 28, 2020
Merged

Fix tooltip location #113

merged 5 commits into from
Nov 28, 2020

Conversation

Mygod
Copy link
Contributor

@Mygod Mygod commented Aug 28, 2020

This patch is not working due to upstream issue: Leaflet/Leaflet#6764

@Mygod Mygod marked this pull request as draft September 17, 2020 14:38
@versx
Copy link
Collaborator

versx commented Sep 24, 2020

Closing this for now until leaflet provides a solution.

@versx versx closed this Sep 24, 2020
@Mygod
Copy link
Contributor Author

Mygod commented Sep 24, 2020

I think the fix is released in v1.7. Try update leaflet to v1.7.1 and merge this patch?

@Mygod Mygod reopened this Sep 24, 2020
@Mygod Mygod marked this pull request as ready for review September 24, 2020 22:02
@TurtIeSocks TurtIeSocks requested a review from versx November 28, 2020 03:25
@versx
Copy link
Collaborator

versx commented Nov 28, 2020

Good to merge?

@TurtIeSocks
Copy link
Contributor

Good to merge?

Yes. Just tweaked it slightly but everything is good to go.

@versx versx merged commit dfdcf67 into WatWowMap:master Nov 28, 2020
@Mygod Mygod deleted the fix-tooltip branch November 30, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants