Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7899 dom manipulator #1

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Issue 7899 dom manipulator #1

merged 2 commits into from
Oct 21, 2024

Conversation

WavesJ99
Copy link
Owner

Closes
nasa#7899

Describe your changes: I am working on a team and trying to contribute to this project. This first contribution is supposed to be small and get us used to creating a pr. The change basically decouples the selection.js module with the DOM manipulation. This also makes selction.js adhere to SRP. We understand this is not a significant change but that is exactly what we we were looking for because of the description of our assignment.

All Submissions:

  • [Y ] Have you followed the guidelines in our [Contributing document] Yes (I think so)(https://github.com/nasa/openmct/blob/master/CONTRIBUTING.md)?
  • [Y ] Have you checked to ensure there aren't other open Pull Requests for the same update/change? Yes
  • [N ] Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins? No

Author Checklist

  • [ Y] Changes address original issue?
  • [N ] Tests included and/or updated with changes?
  • [ Y?] Has this been smoke tested?
  • [ N?] Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • [ N] Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • [Y] Changes appear to address issue?
  • [ ?] Reviewer has tested changes by following the provided instructions?
  • [ Y] Changes appear not to be breaking changes?
  • [ N] Appropriate automated tests included?
  • [ Y] Code style and in-line documentation are appropriate?

@WavesJ99 WavesJ99 self-assigned this Oct 21, 2024
@WavesJ99 WavesJ99 merged commit 2661965 into master Oct 21, 2024
@WavesJ99 WavesJ99 mentioned this pull request Dec 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant