Save interpretations #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* finish download module changes * download notebook * rerun split data module * rerun download module * rerun train_model * rerun evaluation module * rerun interpretation module * combine datasets * combine datasets * split changes * update format * format update * format * finish split data * combine datasets, remove holdout * formatting * rerun pipelines * remove folded class * rerun pipeline * Update utils/download_utils.py Co-authored-by: Dave Bunten <[email protected]> * PR fixes * module docstrings Co-authored-by: Dave Bunten <[email protected]>
gwaybio
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
LGTM
A couple discussion items that you may decide to change:
- I think adding the term
coefficientsto the notebook (currentlyinterpret_model.ipynb) might be more explicit about what going on - Currently, the features are being saved as their index? Is this true? Could you instead use their feature name? This will prevent the scenario of incorrect coefficient index assignment.
- Are these features DP or CP? It's probably worth specifying in the file name.
d33bs
approved these changes
Feb 13, 2023
|
In response to @gwaybio, Suggestions 1 and 2 have been implemented in bc1bf11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review!
In this PR, model coefficients are saved for the final and shuffled baseline models. These coefficients are saved in the tidy long standardized data format.