Add PR curve figure for DeepProfiler multiclass model #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshankern
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Clean PR, LGTM!
I am a bit out of my area with the R code but made a few comments/suggestions that you can decline or accept.
I see that no README is added in this PR. I/someone can add it in a future PR but I think for the sake of clarity and reproducibility a README belongs in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new module
7.figures, which will store all publication-ready figures. In this module, I added a notebook to visualize PR curves. I imagine that we'll visualize all future PR curves using this notebook as well. For now, I added the multiclass model trained with DeepProfiler features.I also add a conda environment for the figure generation and add the figure itself (see below)