Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize performance for subset featurespaces #43
Visualize performance for subset featurespaces #43
Changes from 5 commits
d97d183
a8e496e
75b1be7
246346a
f1af127
a2cf236
d1b552f
c7d0ad3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the plots, I am assuming that the balance type is no longer included, so could this be removed from the code since we have shifted to class-balanced models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this specific command, I am loading a dataset using
readr
. IMO, readr does even a better job than pandas at specifying data type, AKAdtype
. This line that you are highlighting is reading in the column named "balance_type" (and other columns) as a characterdtype
.It is true that we only use balanced models in this visualization, but in order to do so, we need to make sure the column is loaded properly (specifically, as a character), so that we can filter later.