Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class pr curves #6

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Add class pr curves #6

merged 7 commits into from
Dec 12, 2022

Conversation

roshankern
Copy link
Member

This is ready for review! This PR creates precision-recall curves for every phenotypic class using the final and shuffled baseline models on the training and testing data.

roshankern and others added 5 commits December 9, 2022 15:51
* finish download module changes

* download notebook

* rerun split data module

* rerun download module

* rerun train_model

* rerun evaluation module

* rerun interpretation module

* combine datasets

* combine datasets

* split changes

* update format

* format update

* format

* finish split data

* combine datasets, remove holdout

* formatting

* rerun pipelines

* remove folded class

* rerun pipeline

* Update utils/download_utils.py

Co-authored-by: Dave Bunten <[email protected]>

* PR fixes

* module docstrings

Co-authored-by: Dave Bunten <[email protected]>
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for such a nice, bite-sized PR. Happy to take another look prior to merging if you'd like

3.evaluate_model/evaluate_model.sh Outdated Show resolved Hide resolved
utils/evaluate_utils.py Show resolved Hide resolved
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few minor comments but things mostly looked good to me. Please don't hesitate to let me know if you have any questions.

utils/evaluate_utils.py Outdated Show resolved Hide resolved
utils/evaluate_utils.py Outdated Show resolved Hide resolved
utils/evaluate_utils.py Outdated Show resolved Hide resolved
utils/evaluate_utils.py Outdated Show resolved Hide resolved
@roshankern roshankern merged commit 16674be into WayScience:main Dec 12, 2022
@roshankern roshankern deleted the add_class_PR_curves branch December 12, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants