Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for add social factor #342

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Sep 13, 2024

Motivation and Context

Supports for adding social factor.

Jira Link: https://toruslabs.atlassian.net/browse/PD-2801

Description

  • Modify existing function to support adding of new social factor.

How has this been tested?

Developer tested this manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arch1995 arch1995 self-assigned this Sep 13, 2024
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit e91bb98 into master Sep 19, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/allow-add-social-factor branch September 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants