fix: handle URLSearchParams.size missing in slightly older browsers #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #317
Some slightly older browsers, such as Safari <17 and Chrome <113, do not support
URLSearchParams.size
.urlParams.size > 0
, the check for whether aURLSearchParams
object contains any data, returnsfalse
in these browsers, causing the code to treat these params objects as empty and resulting in search and hash elements of the URL being erased when initializing a Web3Auth instance.Description
This PR changes the comparison from
u.size > 0
tou.size !== 0
, which evaluates tofalse
only if attributesize
exists and the object doesn't contain any data.How has this been tested?
The change was tested in Safari for iOS 16.4 and 17, macOS Safari 16 and 17, and Android Chrome 128 by signing into a web3auth client application that uses search and hash params to pass dapp data.
Screenshots (if appropriate):
Types of changes
Checklist: