Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow only auth service urls to set loginId #348

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Allow only auth service urls to set loginId #348

merged 1 commit into from
Nov 10, 2024

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Nov 9, 2024 •
edited
Loading

Motivation and Context

Only allow auth service urls to access/modify loginId

Jira Link:

Description

Only allow auth service urls to access/modify loginId

How has this been tested?

QA team tested this

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

tuna1207
tuna1207 approved these changes Nov 9, 2024
View reviewed changes
Copy link

@tuna1207 tuna1207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 71b33c9 into master Nov 10, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/allowed-origin-check branch November 10, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuna1207 tuna1207 tuna1207 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaitanyapotti @tuna1207