Remove IgnoreImplicitTraps [DO NOT LAND]

CHANGELOG.md

@@ -38,6 +38,9 @@ Current Trunk
  - The build-time option to use legacy WasmGC opcodes is removed.
  - The strings in `string.const` instructions must now be valid WTF-8.
  - The `TraverseCalls` flag for `ExpressionRunner` is removed.
+ - Remove the "ignore implicit effects" options. That is replaced by the
+   now-mature "traps never happen" option which has proven far more useful.
+   - The C API `BinaryenSideEffectImplicitTrap` is removed.
 
 v117
 ----

scripts/diff_metrics.py

@@ -0,0 +1,39 @@
+'''
+Given two files that are the output of --metrics, show a nice diff of them
+'''
+
+import os, sys
+
+def parse(filename):
+  ret = {}
+  for line in open(filename).readlines():
+    if ' : ' in line:
+      item, count = line.split(' : ')
+      ret[item.strip()] = int(count)
+  return ret
+
+a = parse(sys.argv[1])
+b = parse(sys.argv[2])
+
+items = set(list(a.keys()) + list(a.keys()))
+
+longest_name = max([len(item) for item in items])
+
+for item in sorted(list(items)):
+  prefix = item + (' ' * (longest_name - len(item))) + ': '
+
+  if item in a and item not in b:
+    value = f'-{a[item]}'
+  elif item not in a and item in b:
+    value = f'+{a[item]}'
+  else:
+    diff = b[item] - a[item]
+    # ensure a + or - prefix
+    value = str(diff)
+    if diff > 0:
+      value = '+' + value
+
+  # left-justify
+  value = '{:>8}'.format(value)
+  print(f'{prefix} {value}')
+

src/binaryen-c.cpp

@@ -5940,10 +5940,6 @@ BinaryenSideEffects BinaryenSideEffectWritesTable(void) {
   return static_cast<BinaryenSideEffects>(
     EffectAnalyzer::SideEffects::WritesTable);
 }
-BinaryenSideEffects BinaryenSideEffectImplicitTrap(void) {
-  return static_cast<BinaryenSideEffects>(
-    EffectAnalyzer::SideEffects::ImplicitTrap);
-}
 BinaryenSideEffects BinaryenSideEffectTrapsNeverHappen(void) {
   return static_cast<BinaryenSideEffects>(
     EffectAnalyzer::SideEffects::TrapsNeverHappen);

src/binaryen-c.h

@@ -3294,7 +3294,6 @@ BINARYEN_API BinaryenSideEffects BinaryenSideEffectReadsMemory(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectWritesMemory(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectReadsTable(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectWritesTable(void);
-BINARYEN_API BinaryenSideEffects BinaryenSideEffectImplicitTrap(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectTrapsNeverHappen(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectIsAtomic(void);
 BINARYEN_API BinaryenSideEffects BinaryenSideEffectThrows(void);

src/ir/effects.cpp

@@ -66,9 +66,6 @@ std::ostream& operator<<(std::ostream& o, wasm::EffectAnalyzer& effects) {
   if (effects.trap) {
     o << "trap\n";
   }
-  if (effects.implicitTrap) {
-    o << "implicitTrap\n";
-  }
   if (effects.isAtomic) {
     o << "isAtomic\n";
   }