Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language about rounding and behavior that requires further cl… #50

Merged
merged 1 commit into from
May 12, 2015

Conversation

sunfishcode
Copy link
Member

…arification.

@@ -8,7 +8,7 @@ The operations available in the AST are defined here in language-independent
way but closely match operations in many programming languages and are
efficiently implementable on all modern computers.
Floating point arithmetic follows the IEEE 754 standard and unless otherwise
specified uses the round-to-nearest mode.
specified uses the round-to-nearest ties-to-even mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't allow changing rounding mode for now, right? That'll mean that the asm.js polyfill won't produce quite the same results because JS specified different rounding for some ops? Or does asm.js avoid these?

FWIW I'm fine with punting rounding mode support to later, since fenv.h is such a mess. Do you think it should be in future features?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we don't currently allow changing the rounding mode, and there are no present plans to add that functionality. Happily though, JS' and asm.js' rounding mode is also round-to-nearest ties-to-even, so everything lines up here.

I don't see a need to mention fenv.h in future features. People who really want it can still propose it, and then the burden will be on them to figure out if it can be made sane.

@sunfishcode
Copy link
Member Author

Rebased on latest master.

jfbastien added a commit that referenced this pull request May 12, 2015
Clarify language about rounding and behavior that requires further cl…
@jfbastien jfbastien merged commit fac3a4c into master May 12, 2015
@jfbastien jfbastien deleted the convert-semantics branch May 12, 2015 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants