Fix a few minor issues in local validation rules #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing backslash on \LTYPE
Local validation doesn't need `ok`
Locals in a function have structure so need {type t} to
match the valtype
rossberg
approved these changes
Oct 31, 2023
takikawa
commented
Oct 31, 2023
| @@ -48,11 +48,11 @@ Functions :math:`\func` are classified by :ref:`type indices <syntax-typeidx>` r | |||
| \frac{ | |||
| C.\CTYPES[x] = [t_1^\ast] \toF [t_2^\ast] | |||
| \qquad | |||
| (C \vdashlocal t : \init~t)^\ast | |||
| (C \vdashlocal \{\LTYPE~t\} : \init~t)^\ast | |||
There was a problem hiding this comment.
I realized I forgot to add the {type t} here too, to match the validation rules below.
rossberg
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the current rendered local rules:
From this PR:
The main obvious fix is for the
LTYPEwhich is misformatted. Two other fixes:okin the conclusion of the validation rule isn't needed, as there's an output.{ type x, locals t*, body expr }, thet*are locals with shape{type t'}so I think there needs to be some matching on that somewhere in the rule? Here I put it in the conclusion but it could go in the premise too.BTW: the spacing on the
set/unsetseem a bit off too. I think it's due to the\mathrelused for those keywords but wasn't sure what the preferred change was there.