Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-value: fixes compilation errors in examples #1442

Merged
merged 1 commit into from
Apr 14, 2022
Merged

multi-value: fixes compilation errors in examples #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions proposals/multi-value/Overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@
A simple swap function.
```wasm
(func $swap (param i32 i32) (result i32 i32)
(get_local 1) (get_local 0)
(local.get 1) (local.get 0)
)
```

An addition function returning an additional carry bit.
```wasm
(func $add64_u_with_carry (param $i i64) (param $j i64) (param $c i32) (result i64 i32)
(local $k i64)
(set_local $k
(i64.add (i64.add (get_local $i) (get_local $j)) (i64.extend_u/i32 (get_local $c)))
(local.set $k
(i64.add (i64.add (local.get $i) (local.get $j)) (i64.extend_i32_u (local.get $c)))
)
(return (get_local $k) (i64.lt_u (get_local $k) (get_local $i)))
(return (local.get $k) (i64.lt_u (local.get $k) (local.get $i)))
)
```

Expand All @@ -71,7 +71,7 @@ An addition function returning an additional carry bit.
Conditionally manipulating a stack operand without using a local.
```wasm
(func $add64_u_saturated (param i64 i64) (result i64)
($i64.add_u_carry (get_local 0) (get_local 1) (i32.const 0))
(call $add64_u_with_carry (local.get 0) (local.get 1) (i32.const 0))
(if (param i64) (result i64)
(then (drop) (i64.const 0xffff_ffff_ffff_ffff))
)
Expand All @@ -80,14 +80,22 @@ Conditionally manipulating a stack operand without using a local.

An iterative factorial function whose loop doesn't use locals, but uses arguments like phis.
```wasm
(func $pick0 (param i64) (result i64 i64)
(local.get 0) (local.get 0)
)

(func $pick1 (param i64 i64) (result i64 i64 i64)
(local.get 0) (local.get 1) (local.get 0)
)

(func $fac (param i64) (result i64)
(i64.const 1) (get_local 0)
(i64.const 1) (local.get 0)
codefromthecrypt marked this conversation as resolved.
Show resolved Hide resolved
(loop $l (param i64 i64) (result i64)
(pick 1) (pick 1) (i64.mul)
(pick 1) (i64.const 1) (i64.sub)
(pick 0) (i64.const 0) (i64.gt_u)
(call $pick1) (call $pick1) (i64.mul)
(call $pick1) (i64.const 1) (i64.sub)
(call $pick0) (i64.const 0) (i64.gt_u)
(br_if $l)
(pick 1) (return)
(call $pick1) (return)
)
)
```
Expand Down