TypeError for Global constructor with v128 #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the spec requires a `LinkError` to be thrown when the `WebAssembly.Global` constructor is called for type `v128`. This was introduced in WebAssembly/simd#360, but according to the PR description, actually a `TypeError` should be thrown. The PR refers to https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#javascript-api-and-simd-values, and there a `TypeError` is required.
Ms2ger
approved these changes
May 12, 2022
There was a problem hiding this comment.
Seems to have been done in WebAssembly/simd#360; cc @ngzhian @dtig
No objection from me, but I'll wait a little while to merge in case anyone disagrees.
|
LGTM, thanks! |
gahaas
added a commit
to gahaas/wpt
that referenced
this pull request
May 16, 2022
The exception type was incorrect and got fixed recently in WebAssembly/spec#1472
Ms2ger
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 16, 2022
The exception type was incorrect and got fixed recently in WebAssembly/spec#1472
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 23, 2022
… for v128, a=testonly Automatic update from web-platform-tests Fix exception type of WebAssembly.Global for v128 The exception type was incorrect and got fixed recently in WebAssembly/spec#1472 -- wpt-commits: 9daa9178bb6b5397cb3c8d3b731526e8e7e26851 wpt-pr: 34072
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 25, 2022
… for v128, a=testonly Automatic update from web-platform-tests Fix exception type of WebAssembly.Global for v128 The exception type was incorrect and got fixed recently in WebAssembly/spec#1472 -- wpt-commits: 9daa9178bb6b5397cb3c8d3b731526e8e7e26851 wpt-pr: 34072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the spec requires a
LinkErrorto be thrown when theWebAssembly.Globalconstructor is called for typev128. This was introduced in WebAssembly/simd#360, but according to the PR description, actually aTypeErrorshould be thrown. The PR refers to https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#javascript-api-and-simd-values, and there aTypeErroris required.