Don't affect memory on partial out-of-bounds stores #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Mar 7, 2017
| ) | ||
| (func (export "i64.store") (param $a i32) (param $v i64) | ||
| (i64.store (get_local $a) (get_local $v)) | ||
| ) |
There was a problem hiding this comment.
I suggest testing f32 and f64 stores too, since it's not uncommon for JIT implementations to handle those separately from integer stores.
|
lgtm |
rossberg
added a commit
that referenced
this pull request
Mar 10, 2017
generated from commit e077866
rossberg
added a commit
that referenced
this pull request
Mar 10, 2017
generated from commit e077866
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 20, 2023
[test] Add boundary cast tests for ToWebAssemblyValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #438.