-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creation of default i64 global values #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo #827 (comment)
Is this going to go through the stage process, as the BigInt integration proposal is going through?
Good point, though this is a relatively minor change, we should discuss it in the CG. |
I'm fine with it not going through a stage process, but process-wise, you might want to lay out a lightweight set of conditions for a tiny normative change like this to be added to the standard. For example, TC39 requires conformance tests for normative changes, even if they don't go through the stage process. |
That's a good idea, though currently it seems that we've just taken a poll for changes like this. Perhaps there needs to be more for direct changes to the spec, however. |
IMO this needs a CG poll. While I agree this ought to be uncontroversial and I contemplated including this behavior when implementing globals in SpiderMonkey, it's a visible non-bug-fix spec change and should not quietly slip in. |
I agree this should have a CG poll. |
Added to tomorrow's CG, though the agenda is pretty full so it may be pushed to the next meeting. |
We discussed this in the June 26th CG meeting and decided to include this change in the v1 spec. |
Is this ready to merge then? |
See issue #827.