Wasmtime 0.22 #225
Wasmtime 0.22 #225
Conversation
| // Make sure to call `wasmFeatureDetect` inside a promise-chained | ||
| // function so that we can still render table rows for features that | ||
| // we don't have a detector yet. | ||
| .then(() => wasmFeatureDetect[name]()) |
There was a problem hiding this comment.
Makes sense. Do you want to submit a PR to add a detector for module linking though?
There was a problem hiding this comment.
Already filed GoogleChromeLabs/wasm-feature-detect#38 -- it is a little more complicated because WABT doesn't support module linking yet.
|
Thanks! |
| "multiValue": true, | ||
| "mutableGlobals": true, | ||
| "referenceTypes": true, | ||
| "saturatedFloatToInt": true, | ||
| "signExtensions": true, | ||
| "simd": "--enable-simd" | ||
| "simd": "--enable-simd", | ||
| "threads": "--enable-threads" |
There was a problem hiding this comment.
@fitzgen I just remembered why I didn't enable this in the first place. Is the issue I reported at bytecodealliance/wasmtime#1658 resolved?
There was a problem hiding this comment.
We don't have shared memories yet, but we have partial support for atomics instructions. I was under the impression that the flags represented ongoing, work-in-progress support, which is why I added it. Maybe I misunderstood, and the flags should only be added when it is "done" but not on by default yet?
There was a problem hiding this comment.
and the flags should only be added when it is "done" but not on by default yet?
Yeah, basically that.
Can you take a look at this @RReverser? Thanks!