-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #250 (Desugaring) by using constructors instead of context factory methods #662
Conversation
…m a BaseAudioContext or AudioContext.
@@ -1154,7 +1155,8 @@ <h2 id="BaseAudioContext"> | |||
BiquadFilterNode createBiquadFilter() | |||
</dt> | |||
<dd> | |||
Creates a <a><code>BiquadFilterNode</code></a> representing a | |||
This method is DEPRECATED in favor of using the constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent this.
If we're adding constructors, can we actually make the constructors take more arguments than just the context? Like
This requires more design work, but since we're adding something completely new, I think it makes sense to do it now (if we decide to do this) rather than later. |
@rtoy I agree with the idea, so we should start a discussion thread of it. I would rather want to throw a property bag. var hpf = new BiquadFilter(context, {
type: 'highpass',
frequency: 2500
}); |
I actually began to do this but felt it would begin to open up a large |
Note this PR fixes issue #250 |
I agree with the property bag idea, with mandatory first parameter of audio context and second parameter being a dictionary allowing customization. |
Be sure to account for change to playbackCategory re #651 |
This PR needs a bunch of work to incorporate the property bag concept. |
No description provided.