Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SPOJ #870

Merged
merged 3 commits into from
Oct 10, 2024
Merged

added SPOJ #870

merged 3 commits into from
Oct 10, 2024

Conversation

arin17bishwa
Copy link
Contributor

No description provided.

wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated
"uri_check" : "https://www.spoj.com/users/{account}/",
"e_code" : 200,
"e_string" : "<li>Profile</li>",
"m_string" : " was not found on this server.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing this m_string. Consider something like <strong>Innopolis Open 2018</strong>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly odd, apparently they are somewhat showing different pages for non-existent(possibly) users.

The type of page I had consulted was like this:
image

I believe you might had seen this page instead:
image

I am inclined to believe the second one is the actual 404 page, the first one looks too raw to be consumer facing 404. Still I will investigate a bit more.

@arin17bishwa
Copy link
Contributor Author

@WebBreacher: Modified the PR.

I believe the 404 responses were returned in cases where the username didn't match the standards.
image

Note: This means we aren't effectively say missing for illegal usernames

wmn-data.json Outdated
"name" : "SPOJ",
"uri_check" : "https://www.spoj.com/users/{account}/",
"e_code" : 200,
"e_string" : "<li>Profile</li>",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm not seeing the e_string in the response from the server for good/valid accounts. See the image where I visited the defrager user (your known user) and it responded with a valid user profile page. I then looked at the response and searched for the e_string and it was not found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I must have searched for e_string while I was logged in, that would have produced the Profile element.
Corrected it.

@WebBreacher WebBreacher merged commit 600845f into WebBreacher:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants