Update wmn-data.json #906
Merged
Update wmn-data.json #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebBreacher
requested changes
Nov 24, 2024
wmn-data.json
Outdated
| "name" : "Statuspage", | ||
| "uri_check" : "https://{account}.statuspage.io/api/v2/status.json", | ||
| "e_code" : 200, | ||
| "e_string" : "id", |
There was a problem hiding this comment.
This e_string is a bit too plain for us as it could appear on page when a profile is not present. Consider replacing with updated_at
wmn-data.json
Outdated
| "e_string" : "id", | ||
| "m_string" : "<html><body>You are being <a href=\"https://www.statuspage.io\">redirected</a>.</body></html>", | ||
| "m_code" : 302, | ||
| "known" : ["8713981tpdlg"], |
There was a problem hiding this comment.
Please add 1-2 more known accounts. I found a bunch by Googling https://www.google.com/search?q=site%3Astatuspage.io&oq=site%3Astatuspage.io
Amened account identification values and added pretty url.
0x9404
commented
Nov 25, 2024
WebBreacher
reviewed
Nov 25, 2024
wmn-data.json
Outdated
| @@ -6602,6 +6602,17 @@ | |||
| "m_code" : 404, | |||
| "known" : ["carlito", "taylor"], | |||
| "cat" : "social" | |||
| }, | |||
| { | |||
| "name" : "Statuspage", | |||
There was a problem hiding this comment.
Sorry for not catching this.....in the JSON file we alphabetize the sites by their name. Can you move this entry to the S section?
Changed it to alphabetical order.
0x9404
commented
Nov 25, 2024
WebBreacher
reviewed
Nov 25, 2024
wmn-data.json
Outdated
| @@ -659,7 +659,7 @@ | |||
| { | |||
| "name" : "Blogspot", | |||
| "uri_check" : "http://{account}.blogspot.com", | |||
| "strip_bad_char" : ".", | |||
| rip_bad_char" : ".", | |||
There was a problem hiding this comment.
What happened with all these strip_bad_char modifications?
Corrected the accidental changes.
WebBreacher
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed the configuration for statuspage.io.