Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented mock routes #7

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Implemented mock routes #7

merged 8 commits into from
Jan 27, 2025

Conversation

Spkap
Copy link
Collaborator

@Spkap Spkap commented Jan 17, 2025

No description provided.

imApoorva36
imApoorva36 requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@imApoorva36 imApoorva36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes

.gitignore Outdated Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
backend/atlas_backend/models.py Outdated Show resolved Hide resolved
backend/atlas_backend/serializers.py Show resolved Hide resolved
backend/atlas_backend/serializers.py Outdated Show resolved Hide resolved
backend/atlas_backend/serializers.py Outdated Show resolved Hide resolved
backend/atlas_backend/urls.py Outdated Show resolved Hide resolved
backend/atlas_backend/urls.py Show resolved Hide resolved
@vg239 vg239 self-assigned this Jan 20, 2025
imApoorva36
imApoorva36 requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@imApoorva36 imApoorva36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes, also please remove unused imports at the top of the views.py file

Another point to note is that in the start_challenge you have imported library inside the try inside the def... please put all imports at the beginning of the file

backend/backend/settings.py Outdated Show resolved Hide resolved
backend/atlas_backend/views.py Show resolved Hide resolved
backend/atlas_backend/views.py Outdated Show resolved Hide resolved
@imApoorva36
Copy link
Collaborator

LGTM

@imApoorva36 imApoorva36 merged commit 893ebe4 into main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vg239 vg239 vg239 left review comments

@imApoorva36 imApoorva36 imApoorva36 approved these changes

Assignees

@vg239 vg239

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spkap @imApoorva36 @vg239