Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/block variations #108

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Feature/block variations #108

merged 3 commits into from
Jun 28, 2021

Conversation

khleomix
Copy link
Contributor

Closes #107

Link

N/A

Description

  • Add starter block variations:

    • CTA Cover

      • Cover block variation
      • H1 Heading
      • Optional Paragraph block
      • Button block - outline variation and set to 75% width
      • Cover image placeholder
      • Blocks is set to cover but the alignfull class does not work on the wd_s theme. Screenshot below shows block full width on the twenty twenty-one theme
    • Services

      • Columns block variation
      • With 3 columns
      • Innerblocks:
        • Image
        • Heading
        • Paragraph
  • No front end styling added, will be done on theme instead.

  • Added custom icon support for block icons, instead of just using dashicons - this is optional but a nice to have since we sometimes have a lot of blocks and dashicons won't be able to cover all of them.

Screenshot

Block-Variations-–-wd_s

Screen+Recording+2021-06-28+at+11.40.14+PM.mp4

Steps to verify the solution

  1. Create/edit a page
  2. Add the CTA Cover block variation and add content.
  3. Add the Services block variation and add content.
  4. Check to make sure they are both showing.

Other

  • Is this issue accessible? (Section 508/WCAG 2.1AA)
  • Does this pass CrossBrowserTesting.com? (Edge, Safari, Chrome, Firefox)
  • Will this pull request require updating the wiki?

@khleomix khleomix requested a review from gregrickaby June 28, 2021 16:00
@khleomix khleomix self-assigned this Jun 28, 2021
@gregrickaby gregrickaby merged commit cad7a3b into main Jun 28, 2021
@gregrickaby gregrickaby deleted the feature/block-variations branch June 28, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Block Variation Support
2 participants