Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix 3-D Rendering Context tests to test what was intended.
Three of the tests in this file have styles that don't match their names, and thus duplicate other tests also in the file. This makes the styles match the names of the tests as I believe was intended, and thus avoids duplicate tests that are testing the same set of conditions. This also fixes an incorrect pass condition for one set of tests, those testing that an intermediate DOM node causes a 3-D Rendering Context to end. These tests use a pair of 45deg rotations into 3-D space, and an intermediate element that should cause these rotations to be in different 3-D Rendering Contexts and thus be flattened separately. When flattened such rotations should reduce the width by sqrt(2), so two of them, flattened separately, should reduce the width by half. This matches the result for the (not previously tested) case of an element in the normal flow, but produces two new failures for the absolute and fixed position cases. Since one of the tests now has a part that fails, this splits that test into three so the parts can independently report pass or fail. The bug on the two parts that fail is https://crbug.com/1189985. Change-Id: I4bec597318a7054f5a1d8a01b9b2d663fa53658a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774435 Reviewed-by: Chris Harrelson <[email protected]> Commit-Queue: L. David Baron <[email protected]> Cr-Commit-Position: refs/heads/master@{#864750}
- Loading branch information