-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add agent url on config screen #92
Conversation
@rodolfomiranda @2byrds Screen.Recording.2024-02-13.at.11.23.13.PM.mov |
@HunnySajid if they provide the vendor URL it should pre-populate the keria URL in most cases? So I think the keria URL should only be available if they have no vendor URL or if the vendor URL JSON does not provide a keria agent. Thoughts @rodolfomiranda ? |
agree. The normal case is to enter the vendor URL, but we should provide an option for users that use own KERIA instances. A small link with that option may work |
That sounds good. I think if the vendor URL gives you a keria agent then it should be filled in. And you see it IF YOU click the link. If the vendor URL doesn't supply it, then the link automatically opens and the user has to fill it in. |
@rodolfomiranda |
In the previous flow, it was cumbersome for the user to type/paste multiple URLs. e.g vendor_url then agent_url. I have updated the flow, now agentUrls are a part of vendor JSON as an array of string.
If vendor json does not have agentUrls, the extension throws an error JSON loaded without agentUrlsScreen.Recording.2024-02-14.at.11.33.53.PM.movIf vendor JSON has agentUrls then the first URL is selected and flow continues, user can change the URL from dropdown later on: JSON loaded with agentUrlsScreen.Recording.2024-02-14.at.11.34.27.PM.movLet me know how it looks. |
@HunnySajid thank you for posting a look. Does the vendor URL have to have an agent URL? I don't think that should be mandatory, so no error if it's missing. Instead if there is no agent URL the UI makes the user fill it in. Also the user should have the option to fill it in even if the vendor does provide it, as u showed. |
What's the case for a vendor URL to not have a agent URL? also, what's the purpose of having multiple agent URLs in the json? |
What's the case for a vendor URL to not have a agent URL? what's the purpose of having multiple agent URLs in the json Now, I am making following changes:
|
I imagine that the vendor URL will be use for real users that were onboarded previously by the vendior. Only devs or expert users may need to use a custom agentURL, and vendor theming shouldn't be needed. |
@rodolfomiranda i have made updates based on the conversation. Please review |
Video for latest changes: |
Demo review changes: #93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#91