Multisig inception utils for testing #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #212 +/- ##
============================================
Coverage 82.86% 82.86%
============================================
Files 47 47
Lines 4190 4190
Branches 1044 1044
============================================
Hits 3472 3472
Misses 689 689
Partials 29 29 ☔ View full report in Codecov by Sentry. |
lenkan
force-pushed
the
multisig-inception-utils
branch
from
5ff1ce9 to
5ecde32
Compare
lenkan
force-pushed
the
multisig-inception-utils
branch
from
5ecde32 to
94fa319
Compare
|
Would love some feedback if people think this abstraction is good. In that case I could add some more "startMultisigXXX"/"acceptMultisigXXX" functions and refactor the tests to make use of them. Then we can consider moving them into the library. |
pfeairheller
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was creating the reproduction script for WebOfTrust/keria#189 I extract a couple of utility functions for multisig inceptions. I thought it might be useful to include them in the multisig tests to make it a bit easier to comprehend the tests.
In the future, I believe the "accept" type of function for multisig operations would be useful to include in the exposed library.