Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TreeWalker when the root element is a TextNode #286

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix TreeWalker when the root element is a TextNode #286

merged 1 commit into from
Sep 17, 2024

Conversation

kasperskei
Copy link
Contributor

@kasperskei kasperskei commented Sep 17, 2024 •
edited by WebReflection
Loading

Fixes #285

kasperskei
kasperskei commented Sep 17, 2024
View reviewed changes
esm/interface/tree-walker.js Outdated
@@ -42,7 +42,7 @@ export class TreeWalker {
end = documentElement[END];
}
const nodes = [];
while (next !== end) {
while (next !== end && next != null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative option

Suggested change
while (next !== end && next != null) {
while (next !== end && next.nodeType !== NODE_END) {

WebReflection
WebReflection reviewed Sep 17, 2024
View reviewed changes
cjs/interface/tree-walker.js Outdated
@@ -43,7 +43,7 @@ class TreeWalker {
end = documentElement[END];
}
const nodes = [];
while (next !== end) {
while (next !== end && next != null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while (next && next !== end) maybe?

@WebReflection
Copy link
Owner

I think worker.js is an artifact so there's no point in providing a diff of such artifact but then again, all looks good and the change feels minimal enough. Let CI provide its results and I'll merge this.

@WebReflection WebReflection merged commit 73ee30a into WebReflection:main Sep 17, 2024
2 checks passed
@WebReflection
Copy link
Owner

Up and running 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeWalker doesn't work when the root element is a TextNode
2 participants
@kasperskei @WebReflection