Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Service Manager and Event Manager compatibility #36

Merged
merged 8 commits into from
Jun 28, 2016

Conversation

basz
Copy link
Collaborator

@basz basz commented Jun 22, 2016

Tested against a test application. It works... :-)

note : need to remove dev composer stuff

able to quickly review @bakura10 ?

"zendframework/zend-eventmanager": "^2.6 || ^3.0",
"zendframework/zend-servicemanager": "~2.7 || ^3.0",
"zendframework/zend-stdlib": "~2.2 || ^3.0",
"slm/queue": "dev-eventmanager-deprecations as 0.6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to tag slm/queue first and remove that :)

@bakura10
Copy link
Collaborator

Looks good to me !

@basz
Copy link
Collaborator Author

basz commented Jun 22, 2016

thank you @bakura10 . once the PR for the aws zf2 module is merged I will (ask you to) tag 0.6 on all modules.

@bakura10
Copy link
Collaborator

No problem ;). Ping me once it's done!

@basz basz force-pushed the eventmanager-deprecations branch from 165fec7 to 579140e Compare June 23, 2016 08:26
@basz
Copy link
Collaborator Author

basz commented Jun 27, 2016

@bakura the aws PR was merged. Since I have no clue if they will tag it (doesn't look like it) i simply referred too dev-master for now. If you can live with that I invite you to merge and tag 0.6.0 please. For the doctrine package I simply copied the release notes in the release notes fields.

@bakura10
Copy link
Collaborator

I've bumped for a tag. Let's wait a few days and see if they tag it, otherwise I'll tag this one with dev-master as dependency (lathough I don't really like that for a tag release).

@basz
Copy link
Collaborator Author

basz commented Jun 27, 2016

ok sure. no problem here

@basz
Copy link
Collaborator Author

basz commented Jun 27, 2016

@bakura10 done

@bakura10 bakura10 merged commit 255b09d into Webador:master Jun 28, 2016
@bakura10
Copy link
Collaborator

Tagged as 0.6.0!

Thanks for your hard work :).

@basz
Copy link
Collaborator Author

basz commented Jun 28, 2016

thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants