Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Approved Percentage as a Column in the Object List #9855

Closed
michael-smt opened this issue Sep 4, 2023 · 3 comments · Fixed by #9936
Closed

Add Approved Percentage as a Column in the Object List #9855

michael-smt opened this issue Sep 4, 2023 · 3 comments · Fixed by #9936
Assignees
@michael-smt
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. help wanted Extra attention is needed. ux Issues related to user experience.
Milestone
5.1

Comments

@michael-smt
Copy link
Contributor

Describe the problem

Currently in the object list (for projects, components & languages) there is no percentage shown that represents the blue bar.

It is cumbersome to collect a overview on the approval percentage over multiple languages or components.

Describe the solution you'd like

Similar to the "Translated" column there would also be a "Approved" column with the same behaviour (percentage/green checkmark).

Describe alternatives you've considered

Re-use the existing "Translated" column and rename it to "Translated/Approved". When approval is applicable, replace the values in the "Translated" column with the approval percentage. Or show two percentage values. While this saves space, readability suffers and can become confusing.

Making the columns customizeable seem like much too much effort. There is still enough horizontal space left in desktop mode that a additional column would fit.

Screenshots

Screenshot

Additional context

In our translation projects we use the precentage of approved strings as a quality gateway for two things:

  • When using a intermediate language file, the main translation work shall only start when the monolingual base file's approval is over a certain percentage
  • A language shall only be intergrated into the software when it's approval is over a certain percentage (similar to Quantity translation thereshold #3436).
@nijel nijel added enhancement Adding or requesting a new feature. help wanted Extra attention is needed. ux Issues related to user experience. backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. labels Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented.

In case you need this feature soon, please consider helping or push it by funding the development.

michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 5, 2023
@michael-smt
ui: Add approved percentage to the object listing
4846c61 
On narrow resultions it will appear as third item right after the name
and 'Translated' column.

The other columns appear 100px later than before, except
'Unfinished Characters' which appears after 'Comments' at a additonal 100px
instead of 200px. This allows 'Untranslated' to show at the usual 1400px,
so on wide screens no information is lost.

Fixes WeblateOrg#9855
michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 5, 2023
@michael-smt
ui: Add approved percentage to the object listing
bacdb4d 
The new column is displayed in front of the translation percentage because
when approvals are active they probably become the main progress criteria.

On a smaller display resolution it will be shown in third priority after
the name and 'Translated' column.
The other columns appear 100px later than before, except
'Unfinished Characters' which appears after 'Comments' at an additional
100px instead of 200px. This allows 'Untranslated' to show at the usual
1400px, so on common 1440px wide screens no information is lost.

Fixes WeblateOrg#9855
michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 5, 2023
@michael-smt
ui: Add approved percentage to the object listing
2d031f9 
The new column is displayed in front of the translation percentage because
when approvals are active they probably become the main progress criteria.

On a smaller display resolution it will be shown in third priority after
the name and 'Translated' column.
The other columns appear 100px later than before, except
'Unfinished Characters' which appears after 'Comments' at an additional
100px instead of 200px. This allows 'Untranslated' to show at the usual
1400px, so on common 1440px wide screens no information is lost.

Fixes WeblateOrg#9855
@michael-smt michael-smt mentioned this issue Sep 5, 2023
Closed
5 tasks
@nijel nijel added this to the 5.1 milestone Sep 6, 2023
michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 13, 2023
@michael-smt
ui: Add approved percentage to the object listing
6a57829 
Only shows if reviews are enabled in the project.

A simpler implementation compared to MR WeblateOrg#9864.

Resolves WeblateOrg#9855
michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 13, 2023
@michael-smt
ui: Add approved percentage to the object listing
e7639e1 
Only shows if reviews are enabled in the project.

A simpler implementation compared to MR WeblateOrg#9864.

Resolves WeblateOrg#9855
@michael-smt michael-smt mentioned this issue Sep 13, 2023
Merged
5 tasks
@emmapeel2
Copy link
Contributor

Yes please, we also need this on our project.

nijel pushed a commit to michael-smt/weblate that referenced this issue Sep 19, 2023
@michael-smt @nijel
ui: Add approved percentage to the object listing
ade09ac 
Only shows if reviews are enabled in the project.

A simpler implementation compared to MR WeblateOrg#9864.

Resolves WeblateOrg#9855
michael-smt added a commit to michael-smt/weblate that referenced this issue Sep 19, 2023
@michael-smt
ui: Add approved percentage to the object listing
f328d9a 
Only shows if reviews are enabled in the project.

A simpler implementation compared to MR WeblateOrg#9864.

Resolves WeblateOrg#9855
nijel pushed a commit that referenced this issue Sep 19, 2023
@michael-smt @nijel
ui: Add approved percentage to the object listing
0628de9 
Only shows if reviews are enabled in the project.

A simpler implementation compared to MR #9864.

Resolves #9855
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-smt michael-smt

Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. help wanted Extra attention is needed. ux Issues related to user experience.
Projects
None yet
Milestone
5.1
3 participants
@nijel @emmapeel2 @michael-smt