fix(hooks): correct repository full_name extraction #13410
Conversation
Ron31
force-pushed
the
gitlab-project-fullname
branch
from
0a8d37f to
02664bb
Compare
|
Do you know when GitLab has changed the payload? Is it safe to drop support for old version now? |
|
At least since version 15.11 https://archives.docs.gitlab.com/15.11/ee/user/project/integrations/webhook_events.html#push-events Official Support for 15.11 ended 22 Jul 2023 (see https://endoflife.date/gitlab) |
|
Great, then we don't need to support that. Can you please look into the test failure? |
Ron31
force-pushed
the
gitlab-project-fullname
branch
2 times, most recently
from
0df34dc to
2b54480
Compare
|
Hmm, seems like the abstract test class fails when using Django native testing... |
|
Otherwise the DeepSource test failed with "Unit test class with no tests PTC-W0046", which is why i tried to abstract it. |
|
#13513 should address this, let's see if I didn't miss anything. Please rebase on top of that once it is merged. |
|
@Ron31 Can you please rebase? Or allow maintainer edits so that I can rebase? |
Ron31
force-pushed
the
gitlab-project-fullname
branch
from
9fd37cd to
538801d
Compare
Replaces manual parsing of the SSH URL with the provided `path_with_namespace` from the GitLab payload. This ensures accurate retrieval of the repository's full name and avoids potential parsing errors.
Replaces manual parsing of the SSH URL with the provided `path_with_namespace` from the GitLab payload. This ensures accurate retrieval of the repository's full name and avoids potential parsing errors.
Converted `HookBackendTestCase` to an abstract class by adding the `ABC` base and `abstractmethod`. Standardized `test_git` method across test cases to enforce implementation in subclasses.
Co-authored-by: Michal Čihař <[email protected]>
Ron31
force-pushed
the
gitlab-project-fullname
branch
from
538801d to
a3c982b
Compare
Proposed changes
Replaces manual parsing of the SSH URL with the provided
path_with_namespacefrom the GitLab payload. This ensures accurate retrieval of the repository's full name.Checklist
Other information
See https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html for example payloads from GitLab