Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checks): make punctuation spacing ignore markup #13519

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

nijel
Copy link
Member

@nijel nijel commented Jan 15, 2025

Proposed changes

Strip markup before checking for punctuation spacing.

Fixes #6470

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.10 milestone Jan 15, 2025
@nijel nijel self-assigned this Jan 15, 2025
@nijel nijel requested a review from orangesunny as a code owner January 15, 2025 11:41
@nijel nijel enabled auto-merge (rebase) January 15, 2025 11:42
Strip markup before checking for punctuation spacing.

Fixes WeblateOrg#6470
@nijel nijel force-pushed the punctuationspacing branch from b3bc4fb to b609500 Compare January 15, 2025 13:37
@nijel nijel merged commit 3d4ecb8 into WeblateOrg:main Jan 15, 2025
29 checks passed
@nijel nijel deleted the punctuationspacing branch January 15, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check punctuation-spacing should ignore restructured text syntax in rst-text strings
1 participant