Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: reuse path url logic for filesystem #9730

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Aug 11, 2023

Proposed changes

The logic is same and needs to account future categories.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.0 milestone Aug 11, 2023
@nijel nijel self-assigned this Aug 11, 2023
@nijel nijel enabled auto-merge (rebase) August 11, 2023 11:18
The logic is same and needs to account future categories.
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #9730 (0ac1dd1) into main (0cade25) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9730   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         768      768           
  Lines       56283    56283           
  Branches     8749     8749           
=======================================
  Hits        51125    51125           
  Misses       3608     3608           
  Partials     1550     1550           
Files Changed Coverage Δ
...ons/0001_squashed_0074_fix_broken_browser_alert.py 72.34% <ø> (ø)
weblate/trans/mixins.py 96.96% <100.00%> (+0.09%) ⬆️
weblate/trans/models/component.py 80.73% <100.00%> (ø)
weblate/trans/models/project.py 91.78% <100.00%> (-0.06%) ⬇️

@nijel nijel merged commit ab4c6a4 into WeblateOrg:main Aug 11, 2023
@nijel nijel deleted the path-url branch August 11, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant