Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixins: reuse url path for full_slug #9753

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Aug 16, 2023

Proposed changes

These can be same so reduce code duplication and use existing url path.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.0 milestone Aug 16, 2023
@nijel nijel self-assigned this Aug 16, 2023
@nijel nijel enabled auto-merge (rebase) August 16, 2023 08:04
@nijel nijel mentioned this pull request Aug 15, 2023
5 tasks
These can be same so reduce code duplication and use existing url path.
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #9753 (0e89d10) into main (5899ef1) will increase coverage by 0.09%.
Report is 17 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9753      +/-   ##
==========================================
+ Coverage   90.75%   90.84%   +0.09%     
==========================================
  Files         758      768      +10     
  Lines       56065    56191     +126     
  Branches     8719     8741      +22     
==========================================
+ Hits        50883    51048     +165     
+ Misses       3635     3601      -34     
+ Partials     1547     1542       -5     
Files Changed Coverage Δ
weblate/trans/models/component.py 80.74% <ø> (-0.04%) ⬇️
weblate/trans/models/translation.py 87.32% <ø> (-0.05%) ⬇️
weblate/trans/models/unit.py 86.50% <ø> (+0.07%) ⬆️
weblate/trans/mixins.py 96.96% <100.00%> (+0.04%) ⬆️
weblate/trans/tests/test_manage.py 98.58% <100.00%> (ø)
weblate/utils/stats.py 92.56% <100.00%> (-0.03%) ⬇️

... and 32 files with indirect coverage changes

@nijel nijel merged commit d72896e into WeblateOrg:main Aug 16, 2023
@nijel nijel deleted the url-full-slug branch August 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant